Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Seq page revocation #1239

Merged
merged 19 commits into from
Mar 9, 2024
Merged

wip: Seq page revocation #1239

merged 19 commits into from
Mar 9, 2024

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Mar 5, 2024 •
edited
Loading

Summary

  • Add a revocation button to the bottom of the sequence details page if the sequence is from one of my groups
  • Make it redirect to review page
  • Make review page display revocations awaiting approval
  • Make approval endpoint accept revocations awaiting approval
  • Bring in react-toastify and use it to display error messages here: IMO we should deprecate managed error feedback, which requires us to hold state. We can use react-toastify with a single line.

Screenshot

image

PR Checklist

  • All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@theosanderson theosanderson changed the base branch from main to userpage-improvements March 5, 2024 16:24
@theosanderson theosanderson mentioned this pull request Mar 5, 2024
Open
@theosanderson theosanderson added the preview Triggers a deployment to argocd label Mar 5, 2024
@chaoran-chen
Copy link
Member

I think that it is nice to be able to perform "submitter actions" from the sequence detail pages. However, I would introduce a separate visual area to make it clear that it is only visible to oneself due to the submitter status.

A possible inspiration could further be Slack that displays an "Only visible to you" message:

@theosanderson
Copy link
Member Author

Agreed, the design is WIP

@corneliusroemer
Copy link
Contributor

Converted to draft (wip in title)

@corneliusroemer corneliusroemer marked this pull request as draft March 5, 2024 16:57
@theosanderson theosanderson mentioned this pull request Mar 6, 2024
Merged
2 tasks
@theosanderson theosanderson marked this pull request as ready for review March 9, 2024 01:21
@theosanderson theosanderson merged this pull request into userpage-improvements Mar 9, 2024
12 checks passed
@theosanderson theosanderson deleted the seq-page-revocation branch March 9, 2024 01:22
@theosanderson theosanderson restored the seq-page-revocation branch March 9, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
preview Triggers a deployment to argocd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theosanderson @chaoran-chen @corneliusroemer